| Module talk:ko-translit/testcases Sep 20th 2013, 02:27, by Atitarev | | | | Line 13: | Line 13: | | | :::::::I see. Do you want me to write some tests with expected results? I'll do more thorough checks later. --[[User:Atitarev|Anatoli]] <sup>([[User talk:Atitarev|обсудить]]</sup>/<sup>[[Special:Contributions/Atitarev|вклад]])</sup> 06:41, 19 September 2013 (UTC) | | :::::::I see. Do you want me to write some tests with expected results? I'll do more thorough checks later. --[[User:Atitarev|Anatoli]] <sup>([[User talk:Atitarev|обсудить]]</sup>/<sup>[[Special:Contributions/Atitarev|вклад]])</sup> 06:41, 19 September 2013 (UTC) | | | :::::::: Yes, pretty much. Thank you. [[User:Kephir|Keφr]] 06:43, 19 September 2013 (UTC) | | :::::::: Yes, pretty much. Thank you. [[User:Kephir|Keφr]] 06:43, 19 September 2013 (UTC) | | | + | | | | + | :::::::::I've changed my mind about hyphens. Korean Wiktionary uses them and this will make the transliteration much more readable, especially with particle and compound words, easier for learners to see the breakup by syllables. Could you make it default? --[[User:Atitarev|Anatoli]] <sup>([[User talk:Atitarev|обсудить]]</sup>/<sup>[[Special:Contributions/Atitarev|вклад]])</sup> 02:27, 20 September 2013 (UTC) |
Latest revision as of 02:27, 20 September 2013 mekogakopon?[edit] Hmm, don't what's happening but in megaphone#Translations the automatic (2nd) transliteration for "메가폰" (megapon) shows "mekogakopon"? Is another module used? Testing here: 메가폰 (ko), should be "megapon". In Module:ko-translit/testcases it passed OK: {{#invoke:ko-translit|tr|메가폰}} - megapon --Anatoli (обсудить/вклад) 00:24, 19 September 2013 (UTC) - I have removed the module from Module:languages until this is resolved (메가폰 (ko) doesn't produce an erroneous transliteration now) but it did when the module was added to Module:languages. --Anatoli (обсудить/вклад) 03:55, 19 September 2013 (UTC)
- Module:script utilities passes the language and script codes as the second and third arguments to the transliteration function, while this module interprets it as a syllable break. I moved the syllable break argument to the fourth position.
- Which leads to another question: currently some of the testcases expect hyphens as syllable break characters in a few places, but this module will not generate them unless explicitly requested to put syllable breaks everywhere. Should these syllable breaks be forced in these cases too, or the testcases changed? Keφr 05:57, 19 September 2013 (UTC)
- Thank you for fixing. I don't mind if prefix is left optional but the standard way should be without hyphens, IMHO. I don't think anyone will object. Do you mind if I re-add the module to Module:languages and continue testing and adding translations at the same time? I like that you disabled the module for hanja is detected, e.g. . --Anatoli (обсудить/вклад) 06:06, 19 September 2013 (UTC)
- No, the module is hardly complete. There are some final consonant jamo which are currently not handled at all, see source code (two final consonants? it is enough to just plaster them together?). I would like to have some testcases with those. And of course with special-case transitions between those and the initial consonants...
- And Hanja is just passed through as it is. Mixed Hangul-Hanja text will convert only the Hangul part. It may generate some funny output whereas a text is transliterated into itself. Perhaps I could just return nil when the script is set to "Hani"/"Hans"/Hant", or when
text == result. Keφr 06:21, 19 September 2013 (UTC) - Which finals do I need to test, what do you mean by "two final consonants"? --Anatoli (обсудить/вклад) 06:25, 19 September 2013 (UTC)
- I have thrown in a random fragment of the "Korean Syllables" block. Keφr 06:28, 19 September 2013 (UTC)
- I see. Do you want me to write some tests with expected results? I'll do more thorough checks later. --Anatoli (обсудить/вклад) 06:41, 19 September 2013 (UTC)
- Yes, pretty much. Thank you. Keφr 06:43, 19 September 2013 (UTC)
-
-
-
-
-
-
-
-
- I've changed my mind about hyphens. Korean Wiktionary uses them and this will make the transliteration much more readable, especially with particle and compound words, easier for learners to see the breakup by syllables. Could you make it default? --Anatoli (обсудить/вклад) 02:27, 20 September 2013 (UTC)
 |
